Allow wildcard ("*") patterns in ambient module declarations #8939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
pattern_ambient_modules
branch
from
7943883 to
ff70666
Compare
ghost
force-pushed
the
pattern_ambient_modules
branch
from
ff70666 to
3b19825
Compare
| @@ -2135,6 +2136,18 @@ namespace ts { | |||
| [index: string]: Symbol; | |||
| } | |||
|
|
|||
| /** Represents a "prefix*suffix" pattern. */ | |||
|
@vladima can you take a look? |
ghost
mentioned this pull request
| @@ -17627,6 +17641,10 @@ namespace ts { | |||
| if (!isExternalOrCommonJsModule(file)) { | |||
| mergeSymbolTable(globals, file.locals); | |||
| } | |||
| if (file.patternAmbientModules && file.patternAmbientModules.length) { | |||
| (patternAmbientModules || (patternAmbientModules = [])).push(...file.patternAmbientModules); | |||
There was a problem hiding this comment.
i remember we had issues with this pattern for diagnostics, and concat fared better there. consider using patternAmbientModules = concatenate(patternAmbientModules , file.patternAmbientModules) instead.
|
Can you add a you add one more test with a relative file name: declare module "*!text" { .. }
import f from "./file!text"; |
|
other than that 👍 |
added 2 commits
June 9, 2016 11:12
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Half of #6615